Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for application/json mime type in statement output #835

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add support for application/json mime type in statement output #835

merged 2 commits into from
Sep 13, 2023

Conversation

Strunevskiy
Copy link
Contributor

@Strunevskiy Strunevskiy commented Sep 12, 2023 •
edited
Loading

Description

It adds support for application/json mime type in statement output since Livy PySpark kind has %json magic command which return json with application/json mime type in statement output

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • [N/A] If adding a feature, there is an example notebook and/or documentation in the README.md file

@dosubot dosubot bot added the kind:enhancement A new Sparkmagic feature label Sep 12, 2023
@Strunevskiy Strunevskiy marked this pull request as draft September 13, 2023 02:30
@Strunevskiy Strunevskiy marked this pull request as ready for review September 13, 2023 02:30
@Strunevskiy
Copy link
Contributor Author

@devstein could I ask you review this PR ?

@devstein devstein self-requested a review September 13, 2023 02:35
devstein
devstein approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thank you for contributing!

@devstein devstein merged commit 4a8ca9e into jupyter-incubator:master Sep 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein approved these changes

Assignees

@Strunevskiy Strunevskiy

Labels
kind:enhancement A new Sparkmagic feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Strunevskiy @devstein