-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple language servers per document #437
Comments
Have you tried configuring them with https://github.com/pappasam/jedi-language-server#configuration? Also, it seems that jedi by default only provides syntax error diagnostics so any PEP8 may need additional effort to make to work. |
Hi, I don't know what else to try. {
"jedils": {
"serverSettings": {
"python.linting.flake8Enabled": true,
"python.linting.pylintEnabled": true,
"initializationOptions": {
"markupKindPreferred": null,
"jediSettings": {
"autoImportModules": []
},
"completion": {
"disableSnippets": false
},
"diagnostics": {
"enable": true,
"didOpen": true,
"didChange": true,
"didSave": true
},
"workspace": {
"extraPaths": []
}
}
}
}
} I have no idea if this is easy or not, but from the documentation on jedy-language-server (and the fact that it's inspired by python-language-server) I was hoping something could be done. Thanks for the fast reply! |
Started up conda-forge/staged-recipes#13594 in case we want to start supporting/testing with this more formally. I for one am excited to see it in action, as I think They recommend dls for more diagnostic stuff... it's probably worth investigating that, and doing more to handle multiple language servers that target the same (or many) language(s). |
|
This was merged, should be up within the hour. One challenge: |
FYI, jedi server is now auto-detected. Also, the built-in This also affects other functions stability, e.g. hover. |
@sntgluca the workaround for jedi diagnostics was added in the last release, could you confirm if it works well for you? |
Dear @krassowski and @bollwyvl, At first glance, I consider it significantly improved! So far I can tell that it seems to have become helpful, pretty fast for local objects and small packages (i.e. sys). Finally, I see almost all the features are implemented. I will try the newest version then and give feedback on the diagnostics ASAP! I am really impressed by the constant progress. Kudos! |
I actually didn't answer your question below, did I? The diagnostics panel only shows syntax errors. |
This is expected, jedi-language-server only provides syntax errors. Good to have a confirmation that it is working well. We still intend to allow for having two different language servers per document (so that you could use completions from jedi-language-server and diagnostics from another language server) but this has no ETA (it would require some back-and-forth with design and thorough testing so it might happen during one of the future holidays unless someone will contribute earlier). We just released |
Description
Dear @krassowski ,
after the improvements achieved with jedi-language-server for
autocompletion
(#272), I am looking forward to configuring it to work with thecode diagnostics
features.Unfortunately the latter doesn't work out of the box and I can't find any useful debugging/troubleshooting message to share.
Would it be possible to get some help to understand what code diagnostics expects and how to include its configuration?
Many thanks
Reproduce
Expected behavior
Expecting seeing the Diagnostic Panel getting populated. Instead nothing happens.
Thanks!
The text was updated successfully, but these errors were encountered: