Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workflow protobuf for Argo #8

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add Workflow protobuf for Argo #8

wants to merge 12 commits into from

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Dec 6, 2023

closes #7

Overview

This pull request introduces a series of new protobuf objects designed to support the integration of Argo as part of our work on improving the scheduled API. The additions comprehensively support basic Create, Read, Update, and Delete (CRUD) operations with an additional extension for List, which Naas's respective APIs will later consume.

Custom Resource Definitions (CRDs) for the essential resources needed for scheduling workflows on Argo were also added to help with the validation process in the backend. These changes are modeled after the resources outlined in this base Example Workflow provided by Argo, and aim to support its variations with an emphasis on DAG workflow runs.

Main Additions

The PR incorporates several vital components integral to the workflow, as listed below:

  • Metadata: Enhancing data descriptors to support better categorization and identification within the Argo workflow and our organization logic, later to be used as a filtering mechanism of user_id, creation_date, etc.
  • Spec: Detailed specifications for the workflow;
  • Entrypoint: Defining the initial step or action in the workflow;
  • Templates: standard workflow components, ensuring consistency and efficiency;
  • Dag: complex task dependencies workflows;
  • Script: Enabling the embedding of scripts within the workflow;
  • Inputs/Outputs: Defining the expected inputs and outputs gives us the ability to use S3 stores for artifact recovery;

@viniciusdc viniciusdc marked this pull request as draft December 6, 2023 15:36
@viniciusdc viniciusdc changed the title Add Worlflow protobuf for Argo Add Workflow protobuf for Argo Dec 14, 2023
@viniciusdc
Copy link
Contributor Author

I am missing the io.argoproj.workflow.v1alpha1.CronWorkflow, will be adding later once I test this initial resources. I am also missing some more details and validators in the fields of every object there, but that will be added later as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a dev, I need to design the workflow.proto
2 participants