chore: Remove uneeded comments

jupyter-naas · May 3, 2024 · 51f5436 · 51f5436
1 parent ac30eb3
commit 51f5436
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 48 deletions.
diff --git a/naas_python/domains/asset/AssetDomain.py b/naas_python/domains/asset/AssetDomain.py
@@ -22,9 +22,6 @@ def get_asset(self, workspace_id:str, asset_id:str) -> Asset:
         asset = self.adaptor.get_asset(workspace_id, asset_id)
         return asset
 
-    # def get_asset_object(self, workspace_id:str, asset_id:str, password:str) -> dict:
-    #     asset_url = self.adaptor.get_asset_object(workspace_id, asset_id, password)
-    #     return asset_url
 
     def update_asset(self, workspace_id:str, asset_id:str, asset_update: AssetUpdate) -> Asset:
         response = self.adaptor.update_asset(workspace_id, asset_id, asset_update)

diff --git a/naas_python/domains/asset/AssetSchema.py b/naas_python/domains/asset/AssetSchema.py
@@ -19,11 +19,7 @@ def create_asset(self, workspace_id:str, asset_creation:AssetCreation) -> Asset:
 
     @abstractmethod
     def get_asset(self, workspace_id:str, asset_id:str) -> Asset:
-        raise NotImplementedError()
-
-    # @abstractmethod
-    # def get_asset_object(self, workspace_id:str, password:str, asset_id:str, ) -> dict:
-    #     raise NotImplementedError()     
+        raise NotImplementedError()  
 
     @abstractmethod
     def update_asset(self, workspace_id:str, asset_id:str, asset_update: AssetUpdate) -> Asset:
@@ -45,10 +41,6 @@ def create_asset(self, workspace_id:str, asset_creation:AssetCreation) -> Asset:
     def get_asset(self, workspace_id:str, asset_id:str) -> Asset:
         raise NotImplementedError()
 
-    # @abstractmethod
-    # def get_asset_object(self, workspace_id:str, asset_id:str, password:str) -> dict:
-    #     raise NotImplementedError()    
-
     @abstractmethod
     def update_asset(self, workspace_id:str, asset_id:str, asset_update: AssetUpdate) -> Asset:
         raise NotImplementedError()    
@@ -59,24 +51,4 @@ def delete_asset(self, workspace_id:str, asset_id:str) -> None:
 
 # Primary Adaptor
 class IAssetPrimaryAdaptor:
-    pass
-# class IAssetInvoker(metaclass=ABCMeta):
-#     @abstractmethod
-#     def create_asset(self, **kwargs):
-#         raise NotImplementedError()
-
-#     @abstractmethod
-#     def get_asset(self, **kwargs):
-#         raise NotImplementedError()
-
-#     @abstractmethod
-#     def get_asset_object(self, **kwargs):
-#         raise NotImplementedError()
-
-#     @abstractmethod
-#     def update_asset(self, **kwargs):
-#         raise NotImplementedError()
-
-    # @abstractmethod
-    # def delete_asset(self, **kwargs):
-    #     raise NotImplementedError()
+    pass
diff --git a/naas_python/domains/asset/adaptors/primary/SDKAssetAdaptor.py b/naas_python/domains/asset/adaptors/primary/SDKAssetAdaptor.py
@@ -2,13 +2,11 @@
 from naas_python.domains.asset.AssetSchema import (
     IAssetDomain,
     IAssetPrimaryAdaptor,
-    # IAssetInvoker,
     Asset,
     AssetCreation,
     AssetUpdate
 )
 
-# class SDKAssetAdaptor(IAssetInvoker):
 class SDKAssetAdaptor(IAssetPrimaryAdaptor):
     domain: IAssetDomain
 
@@ -25,10 +23,6 @@ def get_asset(self, workspace_id:str, asset_id:str) -> Asset:
         asset = self.domain.get_asset(workspace_id, asset_id)
         return asset
 
-    # def get_asset_object(self, workspace_id:str, asset_id:str, password:str) -> dict:
-    #     asset_url = self.domain.get_asset_object(workspace_id, asset_id, password)
-    #     return asset_url
-
     def update_asset(self, workspace_id:str, asset_id:str, asset_update: AssetUpdate) -> Asset:
         asset = self.domain.update_asset(workspace_id, asset_id, asset_update)
         return asset

diff --git a/naas_python/domains/asset/adaptors/secondary/NaasAssetAPIAdaptor.py b/naas_python/domains/asset/adaptors/secondary/NaasAssetAPIAdaptor.py
@@ -62,15 +62,6 @@ def get_asset(self, workspace_id:str, asset_id:str) -> Asset:
         )
         return self._handle_response(api_response)
 
-    # @BaseAPIAdaptor.service_status_decorator
-    # def get_asset_object(self, workspace_id:str, asset_id:str, password:str) -> dict:
-    #     _url = f"{self.host}/workspace/{workspace_id}/asset/{asset_id}/object/?password={password}"
-    #     api_response = self.make_api_request(
-    #         requests.get,
-    #         _url
-    #     )
-    #     return self._handle_response(api_response)
-
     @BaseAPIAdaptor.service_status_decorator
     def update_asset(self, workspace_id:str, asset_id:str, asset_update: AssetUpdate) -> Asset:
         _url = f"{self.host}/workspace/{workspace_id}/asset/{asset_id}"