fix: On a 500 status code do not try to read json

jupyter-naas · Feb 20, 2024 · d99f855 · d99f855
1 parent fc21971
commit d99f855
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/naas_python/utils/domains_base/secondary/BaseAPIAdaptor.py b/naas_python/utils/domains_base/secondary/BaseAPIAdaptor.py
@@ -89,8 +89,8 @@ def make_api_request(
             return api_response
 
         except requests.exceptions.HTTPError as e:
-            _response = api_response.json()
             if api_response.status_code == 401:
+                _response = api_response.json()
                 _message = ""
                 if "error_message" in _response:
                     _message = _response["error_message"]
@@ -103,13 +103,7 @@ def make_api_request(
                     e,
                 )
             elif api_response.status_code == 500:
-                _message = ""
-                if "error_message" in _response:
-                    _message = _response["error_message"]
-                elif "detail" in _response:
-                    _message = _response["detail"]
-                else:
-                    _message = "Internal Server Error"
+                _message = "Internal Server Error"
                 raise ServiceStatusError(_message, e)
             else:
                 # Other status codes will be handled by the calling method