Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Amphion with URDF Loaders and Three.js #30

Merged
merged 42 commits into from
Aug 11, 2023
Merged

Replace Amphion with URDF Loaders and Three.js #30

merged 42 commits into from
Aug 11, 2023

Conversation

IsabelParedes
Copy link
Member

This PR

  • removes Amphion dependency
  • removes the need of a rosbridge connection through Amphion
  • allows mesh files to be loaded directly with three.js
  • adds support for Xacro files

@IsabelParedes
Add urdf loader
60f16d6
@IsabelParedes
Replace viewer with scene
517a89f
@IsabelParedes
Render primitive shapes
54687c5
@IsabelParedes
Fix background color change
0f839f1
@IsabelParedes
Load mesh files
43ff2bf
@IsabelParedes
Remove amphion
62e1316
@IsabelParedes
Fix joint controller
62f67ff
@IsabelParedes
Fix live editor
c1d07a2
@IsabelParedes
Fix orbit controls
2861b5d
@IsabelParedes
Add grid
5436681
@IsabelParedes
Handle joint overflow in gui
c1faec5
@IsabelParedes
Fix window resizing
ecd87fc
@IsabelParedes
Fix lighting
d9b1a84
@IsabelParedes
Enable changes in working path
d460c3c
@IsabelParedes
Add basic template for new files
c75b9a5
@IsabelParedes
Fix loader error with modified url's
f0d40ff
@IsabelParedes
Fix duplicate robot error
ca7387a
@IsabelParedes
Add grid height control
e70a910
@IsabelParedes
WIP loading xacro files
78b4747
@IsabelParedes
Working xacro loader
01a7810
@IsabelParedes
Fix xacro working path
aff8c05
@IsabelParedes
Create controls class
9656506
@IsabelParedes
Replace controls gui
4738f1a
@IsabelParedes
WIP add renderer class
7aac531
@IsabelParedes
Link scene controls to renderer
6991f47
@IsabelParedes
Replace renderer
9fe614f
@IsabelParedes
Set default colors to match theme in controls
9425eaf
@IsabelParedes
Add loader class
9388f93
@IsabelParedes
Fix error with editing xacros
2b393fb
@IsabelParedes
Prettify
ecfb832
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Binder 👈 Launch a Binder on branch ihuicatl/jupyterlab-urdf/loaders

@IsabelParedes IsabelParedes added the enhancement New feature or request label Aug 9, 2023
@IsabelParedes
Copy link
Member Author

@IsabelParedes IsabelParedes added the bug Something isn't working label Aug 10, 2023
@IsabelParedes IsabelParedes marked this pull request as ready for review August 10, 2023 16:31
@IsabelParedes IsabelParedes merged commit fbf7265 into jupyter-robotics:main Aug 11, 2023
6 checks passed
@IsabelParedes IsabelParedes deleted the loaders branch August 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@IsabelParedes