fix(k8s): handle status of deleted Pod correctly #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst deleting a kernel namespace returns a v1.Status, deleting a Pod will return a v1.Pod and its status field is a v1.PodStatus, not a string. The existing code currently raises an exception as it attempts to do an 'in' check against the V1PodStatus type rather than a string as it expected. This is logged as: > Error occurred deleting pod: argument of type 'V1PodStatus' is not iterable
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
kevin-bates
approved these changes
May 6, 2022
There was a problem hiding this comment.
These changes look great @dnwe - thank you for cleaning up this area.
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst deleting a kernel namespace returns a v1.Status, deleting a Pod
will return a v1.Pod and its status field is a v1.PodStatus, not a
string.
The existing code currently raises an exception as it attempts to do an
'in' check against the V1PodStatus type rather than a string as it
expected. This is logged as: