You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to run the newly re-added make env target, environment creation was failing citing "Directory '..' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.". The directory in requirements.yml is updated here (to .) to point to the correct location for doc dependency installation.
After this change was made, another error was raised (below) where conda was unable to resolve the project requirement for jinja2>=3.1 (from pyproject.toml) with the doc requirement for jinja2<3.1.
The conflict is caused by:
The user requested jinja2<3.1
jupyter-enterprise-gateway 3.0.0.dev0 depends on jinja2>=3.1
The jinja cap in doc-requirements.txt (in place due to sphinx-doc/sphinx#10291) is removed here as the cited issue no longer occurs as of sphinx==4.0.2. The make env target now succeeds.
I also updated the jinja dependency to >=3.1 in requirements.yml to bring it in line with the version in pyproject.toml (although I'm not sure if there are reasons for this difference that would make this ill-advised; please advise if so 🙂 ).
Thanks for submitting your first pull request! You are awesome! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋
Thanks! I tested this on my machine too as was able to run the make env command as well. Since the conda env was able to be build this time around, I was also able to validate that make remove-env still works as intended as well
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to run the newly re-added
make envtarget, environment creation was failing citing "Directory '..' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.". The directory inrequirements.ymlis updated here (to.) to point to the correct location for doc dependency installation.After this change was made, another error was raised (below) where conda was unable to resolve the project requirement for
jinja2>=3.1(frompyproject.toml) with the doc requirement forjinja2<3.1.The jinja cap in
doc-requirements.txt(in place due to sphinx-doc/sphinx#10291) is removed here as the cited issue no longer occurs as ofsphinx==4.0.2. Themake envtarget now succeeds.I also updated the
jinjadependency to>=3.1inrequirements.ymlto bring it in line with the version inpyproject.toml(although I'm not sure if there are reasons for this difference that would make this ill-advised; please advise if so 🙂 ).