Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency requirements to support make env target #1108

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

kiersten-stokes
Copy link
Collaborator

When attempting to run the newly re-added make env target, environment creation was failing citing "Directory '..' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.". The directory in requirements.yml is updated here (to .) to point to the correct location for doc dependency installation.

After this change was made, another error was raised (below) where conda was unable to resolve the project requirement for jinja2>=3.1 (from pyproject.toml) with the doc requirement for jinja2<3.1.

The conflict is caused by:
    The user requested jinja2<3.1
    jupyter-enterprise-gateway 3.0.0.dev0 depends on jinja2>=3.1

The jinja cap in doc-requirements.txt (in place due to sphinx-doc/sphinx#10291) is removed here as the cited issue no longer occurs as of sphinx==4.0.2. The make env target now succeeds.

I also updated the jinja dependency to >=3.1 in requirements.yml to bring it in line with the version in pyproject.toml (although I'm not sure if there are reasons for this difference that would make this ill-advised; please advise if so 馃檪 ).

@welcome
Copy link

welcome bot commented Jun 10, 2022

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 馃憢

Welcome to the Jupyter community! 馃帀

@bloomsa
Copy link
Contributor

bloomsa commented Jun 11, 2022

Thanks! I tested this on my machine too as was able to run the make env command as well. Since the conda env was able to be build this time around, I was also able to validate that make remove-env still works as intended as well

Copy link
Contributor

@rahul26goyal rahul26goyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @kiersten-stokes for fixing it.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kiersten-stokes.

@kevin-bates kevin-bates merged commit b0e30ea into jupyter-server:main Jun 11, 2022
@welcome
Copy link

welcome bot commented Jun 11, 2022

Congrats on your first merged pull request in this project! 馃帀
congrats
Thank you for contributing, we are very proud of you! 鉂わ笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants