Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the components from jupyterlab-system-monitor #191

Closed
jtpio opened this issue Apr 26, 2023 · 1 comment · Fixed by #202
Closed

Integrate the components from jupyterlab-system-monitor #191

jtpio opened this issue Apr 26, 2023 · 1 comment · Fixed by #202

Comments

@jtpio
Copy link
Member

jtpio commented Apr 26, 2023

Problem

Currently the jupyterlab-system-monitor depends on jupyter-resource-usage but still needs to be installed separately.

It also depends on a jupyterlab-topbar package which is probably going to be abandoned after JupyterLab 4 is released.

But with JupyterLab 4 the use of the top area is going to be slightly changed. There are also new elements in the toolbar for example when RTC is enabled.

Proposed Solution

When making this extension compatible with JupyterLab 4, it will be great to also consider incorporating the UI elements from https://github.com/jtpio/jupyterlab-system-monitor:

Maybe they could be hidden hidden by default and enabled via the settings.

Additional context

Link to the extension: https://github.com/jtpio/jupyterlab-system-monitor

This might be something relevant to do before #185.

This would help fix these issues:

@jtpio
Copy link
Member Author

jtpio commented May 12, 2023

Tagging as a "good first issue" in case someone look like to have a look at it.

It would be great to have that in jupyter-resource-usage before releasing a version for JupyterLab 4 compatibility.

Probably the work mostly involves moving code from https://github.com/jtpio/jupyterlab-system-monitor/tree/main/packages https://github.com/jupyter-server/jupyter-resource-usage/tree/main/packages/labextension, for example in multiple different plugins.

This was referenced Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant