fix PATCH job definitions active

jupyter-server · Oct 7, 2022 · 4b00854 · 4b00854
1 parent a842625
commit 4b00854
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/jupyter_scheduler/handlers.py b/jupyter_scheduler/handlers.py
@@ -103,7 +103,11 @@ async def post(self):
     @tornado.web.authenticated
     async def patch(self, job_definition_id):
         payload = self.get_json_body()
-        await ensure_async(self.scheduler.update_job_definition(UpdateJobDefinition(**payload)))
+        await ensure_async(
+            self.scheduler.update_job_definition(
+                UpdateJobDefinition(**payload, job_definition_id=job_definition_id)
+            )
+        )
         self.set_status(204)
         self.finish()
 

diff --git a/jupyter_scheduler/models.py b/jupyter_scheduler/models.py
@@ -195,6 +195,7 @@ class UpdateJobDefinition(BaseModel):
     url: Optional[str] = None
     timezone: Optional[str] = None  # Should be a timezone e.g., US/Eastern, Asia/Kolkata
     output_filename_template: Optional[str] = OUTPUT_FILENAME_TEMPLATE
+    active: bool
 
 
 class ListJobDefinitionsQuery(BaseModel):