Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel not chosen or kernel choice not explicitly saved results in Job creation error #215

Closed
andrii-i opened this issue Oct 27, 2022 · 3 comments · Fixed by #243
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@andrii-i
Copy link
Collaborator

andrii-i commented Oct 27, 2022

Description

When job is created immediately after Notebook is created kernel (metadata field nb.metadata.kernelspec["name"]) is sometimes not set which results in failure to create a job.

When user creates a notebook, he gets "choose kernel" popup. After choice in the popup is made, user needs to explicitly save the notebook (answering "Rename?" dialog on the way) to actually set the kernel.

Reproduce

  1. Create new notebook in jupyterlab
  2. Select kernel in the popup window
  3. Populate some cells
  4. Attempt to create a job for this notebook
  5. Note that job creation results in failure with kernelspec error

Expected behavior

Kernel is set upon selection in popup window upon creation of notebook OR more meaningful error message is provided on job creation fail that helps user to diagnose and remedy the error (something like "kernel is not set for Mynotebook.ipynb notebook, make sure you chose a kernel and saved a notebook after selection")

kernel

@andrii-i andrii-i added the bug Something isn't working label Oct 27, 2022
@ellisonbg
Copy link
Contributor

ellisonbg commented Oct 27, 2022 via email

@andrii-i
Copy link
Collaborator Author

Should we allow users to pick a kernel in Additional options if one is not in the notebook?

I think it would be very helpful, especially in combination with descriptive error message

@andrii-i
Copy link
Collaborator Author

when the user clicks on the “Create Notebook Job” icon in the notebook toolbar or context menu items should we trigger a document save”

-solution proposed by @ellisonbg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants