Output formats are not passed properly from Job Details view to Create Job form

[JasonWeill]

Description

In rerunJob in job-detail.tsx, the output formats are passed as name: format, label: format where format is 'ipynb' or 'HTML':

jupyter-scheduler/src/mainviews/job-detail.tsx

Lines 64 to 78 in c776e2d

	const rerunJob = () => {
	const initialState: ICreateJobModel = {
	inputFile: job?.input_uri ?? '',
	jobName: job?.name ?? '',
	outputPath: job?.output_prefix ?? '',
	environment: job?.runtime_environment_name ?? '',
	parameters:
	job && job.parameters
	? Object.keys(job.parameters).map(key => getParam(key))
	: undefined,
	outputFormats: job?.output_formats?.map(format => ({
	name: format,
	label: format
	}))
	};

Because these output formats do not match those in the environment's output formats list, they will never be selected on the create job form.

Expected behavior

The jobs should be in the same format as is used in the environments list's environment definition: for example, { name: 'ipynb', label: 'Notebook' }.

Context

The utility function outputFormatsForEnvironment is used to get an environment's properly formed output formats.

[ellisonbg]

@andrii-i @jweill-aws is this still valid?

[andrii-i]

Implementation changed but the issue is still valid. Now it's about adding missing outputFormats conversion functionality in convertDescribeJobtoJobDetail function of model.ts (line 130)

jupyter-scheduler/src/model.ts

Lines 108 to 140 in 5fd1856

	export function convertDescribeJobtoJobDetail(
	dj: Scheduler.IDescribeJob
	): IJobDetailModel {
	// Convert parameters
	const jdParameters = Object.entries(dj.parameters ?? {}).map(
	([pName, pValue]) => {
	return {
	name: pName,
	value: pValue
	};
	}
	);
	// TODO: Convert outputFormats
	return {
	jobId: dj.job_id,
	jobName: dj.name ?? '',
	inputFile: dj.input_uri,
	outputPath: dj.output_uri,
	outputPrefix: dj.output_prefix,
	environment: dj.runtime_environment_name,
	parameters: jdParameters,
	outputFormats: [],
	computeType: dj.compute_type,
	idempotencyToken: dj.idempotency_token,
	tags: dj.tags,
	status: dj.status,
	createTime: dj.create_time,
	updateTime: dj.update_time,
	startTime: dj.start_time,
	endTime: dj.end_time
	};
	}