Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If input file has a directory, only the directory appears in the "input file" column #68

Closed
JasonWeill opened this issue Sep 30, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@JasonWeill
Copy link
Collaborator

Description

If the input file for a notebook job has a relative path including a subdirectory, the "input" column shows only the subdirectory. The filename does not appear.

Reproduce

  1. Create a notebook job where the input file is in a subdirectory: foo/bar.ipynb.
  2. View the jobs list.
  3. The directory foo, but not the filename bar.ipynb, appears in the "Input file" column.

Expected behavior

foo/bar.ipynb or bar.ipynb appears.

Context

Seen in a 2022-09-30 demo.

@JasonWeill JasonWeill added the bug Something isn't working label Sep 30, 2022
@JasonWeill
Copy link
Collaborator Author

JasonWeill commented Sep 30, 2022

Screen shot:

issue-68

@ellisonbg
Copy link
Contributor

I thought we talked about making the input file non-editable in the UI. Given how users open the form if we introduce that constraints, we know that the file exists and is a valid path.

@ellisonbg
Copy link
Contributor

See #78 for details on making the input file read only.

@JasonWeill
Copy link
Collaborator Author

This doesn't seem to be a problem in the OSS code; I just ran a file that is in a subdirectory, and in the "Input file" column, I see the filename without the directory. Closing.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants