[WIP] General UI improvements #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 17, 2022 12:21
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
|
This was referenced Sep 19, 2022
Merged
andrii-i
reviewed
Sep 19, 2022
| import { AvailableSizes } from '../size'; | ||
|
|
||
| export interface IBoxProps { | ||
| size?: AvailableSizes; |
There was a problem hiding this comment.
Nit (as seen in codebase / mentioned in reviews): should optional properties go last?
|
Superseded by #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time today building reusable layout components to help make the UI consistent and responsive. Still working on this, and have probably broken things in the meantime. Will continue tomorrow.