Pass version_spec in check-release
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
commented
Oct 20, 2021
| @@ -22,6 +22,7 @@ runs: | |||
| dry_run: true | |||
| token: ${{ inputs.token }} | |||
| changelog: ${{ inputs.changelog }} | |||
| version_spec: ${{ env.RH_VERSION_SPEC }} | |||
There was a problem hiding this comment.
We could also make that an input of the check release workflow, something like:
version_spec:
description: "New Version Specifier"
required: false
default: ""
There was a problem hiding this comment.
I think that makes sense.
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 19 19
Lines 2273 2273
Branches 280 280
=======================================
Hits 1927 1927
Misses 250 250
Partials 96 96 Continue to review full report at Codecov.
|
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #189