Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing version from package.json #46

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 28, 2021

Trying to use the Draft Changelog workflow on a repo with a version in the package.json, which is common in monorepos.

See this failing run for reference: https://github.com/jtpio/jupyter_releaser/runs/2933424228

@blink1073 blink1073 added the bug Something isn't working label Jun 28, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jun 28, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member Author

jtpio commented Jun 28, 2021

Not sure this is enough to handle workspaces, currently seeing another error when testing with this change:

image

But this might actually be something different related to how the packages are retrieved with glob patterns, returning too many results:

for path in glob(pattern, recursive=True):

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #46 (1b8253d) into master (9129099) will decrease coverage by 0.10%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   88.51%   88.40%   -0.11%     
==========================================
  Files          15       15              
  Lines        1715     1725      +10     
  Branches      205      208       +3     
==========================================
+ Hits         1518     1525       +7     
- Misses        122      124       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
jupyter_releaser/lib.py 75.89% <66.66%> (-0.48%) ⬇️
jupyter_releaser/npm.py 81.06% <90.90%> (+0.44%) ⬆️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8285f2d...1b8253d. Read the comment docs.

@jtpio
Copy link
Member Author

jtpio commented Jun 28, 2021

Not sure this is enough to handle workspaces, currently seeing another error when testing with this change:

Will track that in a separate issue.

@jtpio jtpio mentioned this pull request Jun 28, 2021
@jtpio
Copy link
Member Author

jtpio commented Jun 30, 2021

Will track that in a separate issue.

Opened #48, so we can go ahead and merge this one as an incremental improvement.

@jtpio jtpio merged commit 28db9ca into jupyter-server:master Jun 30, 2021
@jtpio jtpio deleted the handle-missing-version branch June 30, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants