-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing version
from package.json
#46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Not sure this is enough to handle workspaces, currently seeing another error when testing with this change: But this might actually be something different related to how the packages are retrieved with glob patterns, returning too many results: jupyter_releaser/jupyter_releaser/npm.py Line 154 in 8285f2d
|
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 88.51% 88.40% -0.11%
==========================================
Files 15 15
Lines 1715 1725 +10
Branches 205 208 +3
==========================================
+ Hits 1518 1525 +7
- Misses 122 124 +2
- Partials 75 76 +1
Continue to review full report at Codecov.
|
Will track that in a separate issue. |
Opened #48, so we can go ahead and merge this one as an incremental improvement. |
Trying to use the Draft Changelog workflow on a repo with a
version
in thepackage.json
, which is common in monorepos.See this failing run for reference: https://github.com/jtpio/jupyter_releaser/runs/2933424228