Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Full Release workflow to the example workflows #501

Merged
merged 3 commits into from Apr 5, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 30, 2023

Fixes #175

For small projects where we don't necessarily need to check the changelog, it can be convenient to make a release in one go using a single workflow.

This PR adds a full-release.yml workflow to the example-workflows folder called Step 1 + 2: Full Release. Happy to go with another name if needed.

Generally we should still encourage the 2 steps approach to allow for checking the new version numbers and changelog are correct. So it's not mentioned in the documentation for now but could be added if folks find it useful.

Here is an example run of such workflow: https://github.com/jtpio/ipylab/actions/runs/4561211046/jobs/8046913448

image

cc @martinRenou

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (5c89302) 81.82% compared to head (358f6eb) 81.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   81.82%   81.65%   -0.18%     
==========================================
  Files          20       20              
  Lines        2823     2823              
  Branches      508      508              
==========================================
- Hits         2310     2305       -5     
- Misses        385      390       +5     
  Partials      128      128              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtpio jtpio added the documentation Improvements or additions to documentation label Mar 30, 2023
@jtpio jtpio requested a review from blink1073 April 4, 2023 17:03
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 9f57027 into jupyter-server:main Apr 5, 2023
20 of 21 checks passed
@jtpio jtpio deleted the full-release-workflow branch April 5, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog and Full Release in the same workflow
2 participants