Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically set the NPM tag #510

Merged
merged 7 commits into from Jun 20, 2023

Conversation

fcollonval
Copy link
Member

The current publishing action does not deal with setting the NPM tag although we look if the release is a prerelease or not.

This sets the npm tag depending on whether the release is a prerelease or not. It adds also a new npm_tag option to override the tag.

This was tested successfully on https://github.com/jupyterlab/jupyterlab-git/actions/runs/5312255052/jobs/9616511151

@fcollonval fcollonval added the enhancement New feature or request label Jun 19, 2023
@fcollonval
Copy link
Member Author

I'm not seeing why the test jupyter_releaser/tests/test_cli.py::test_publish_assets_npm is failing. I guess this is due to the new arguments. But I'm missing what is wrong.

@fcollonval
Copy link
Member Author

@blink1073 I'm unsure what to do about the linter error (it is not a modified line):

jupyter_releaser/lib.py:352:13: B028 No explicit `stacklevel` keyword argument found

Do you have any advice?

@blink1073
Copy link
Contributor

Do you have any advice?

See my commit. :)

@blink1073 blink1073 enabled auto-merge (squash) June 20, 2023 17:04
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 disabled auto-merge June 20, 2023 17:27
@blink1073 blink1073 merged commit b1388d0 into jupyter-server:main Jun 20, 2023
17 checks passed
@fcollonval fcollonval deleted the ft/support-npm-tag branch June 21, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants