Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel_actions/v1 spec expects field that is not available #1299

Closed
allstrive opened this issue Jul 7, 2023 · 3 comments
Closed

kernel_actions/v1 spec expects field that is not available #1299

allstrive opened this issue Jul 7, 2023 · 3 comments
Labels

Comments

@allstrive
Copy link
Contributor

Description

When Enterprise Gateway fails to create a kernel for the jupyter notebook, the response is not expected to contain any kernel ID. However, the kernel_actions/v1.yaml expects that kernel_id be present. The error response results in subsequent event validation error due to kernel_id that is set to None.

Reproduce

  1. Try to launch a Gateway Kernel with spec that would gurantee failure
  2. When Gateway client fails - it generates subsequent validation error
  3. Expected event is not generated as a result

Expected behavior

When the Gateway fails to launch kernel it should also log that as an event

Context

  • Operating System and version: Not relevant
  • Browser and version: Not relevant
  • Jupyter Server version: Not relevant
  • Jupyter-Server version : 2.7.0
Troubleshoot Output

Command Line Output

Browser Output

@allstrive allstrive added the bug label Jul 7, 2023
@allstrive allstrive changed the title kernel_actions/v1 spec expects fields that are not available kernel_actions/v1 spec expects field that is not available Jul 7, 2023
@kevin-bates
Copy link
Member

This condition is not exclusive to the use of a gateway - correct? Any failure of a kernel's start will not (necessarily) have a kernel_id present and, as a result, violate the event schema's validation. I just want to make sure my understanding is correct and it's just less common for local start failures to occur (although it could be easily simulated by, for example, invalidating the argv stanza's content in the kernel.json file).

@allstrive
Copy link
Contributor Author

Yes, that's correct .

@Zsailer
Copy link
Member

Zsailer commented Aug 7, 2023

Solved by #1300

@Zsailer Zsailer closed this as completed Aug 7, 2023
ojarjur added a commit to ojarjur/jupyter-extensions that referenced this issue Sep 29, 2023
The new release version is `0.0.4`.

This also updates the `jupyter-server` dependency to `>=2.7.3`.

That is so users pick up the fix for
[this issue](jupyter-server/jupyter_server#1299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants