Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does jupyter server support unix sockets? #307

Closed
goanpeca opened this issue Sep 16, 2020 · 8 comments
Closed

Does jupyter server support unix sockets? #307

goanpeca opened this issue Sep 16, 2020 · 8 comments

Comments

@goanpeca
Copy link
Contributor

From Discourse:

@mlucool
Hi, Does jupyterlab support unix sockets? If so, how do I configure it? It seems Notebook supports them (https://jupyter-notebook.readthedocs.io/en/stable/changelog.html#release-6-1-0) and tornado does too (tornadoweb/tornado#2671). If this feature is missing, which is the right repo to log an issue for this, jupyter_server?

@kevin-bates kevin-bates changed the title Does jupyterlab support unix sockets? Does jupyter server support unix sockets? Sep 16, 2020
@kevin-bates
Copy link
Member

Hi Gonzalo,
The sockets PR is on the list of pull requests to port over from Notebook - time just hasn't been very cooperative.

Since this is purely a server issue, I took the liberty of updating the title since I believe you meant to say 'jupyter server' anyway. (If not, you could have unix sockets in jupyterlab by using lab 2.x since that still uses the notebook server if I'm not mistaken.)

@goanpeca
Copy link
Contributor Author

Thanks for the update @kevin-bates

I believe you meant to say 'jupyter server'

Yes :-p

@PromyLOPh
Copy link

Is anyone working on porting the feature from Notebook right now? We’re stuck on JupyterLab v2, because v3.0 essentially removed this feature.

@kevin-bates
Copy link
Member

Good point on the perceived regression issue. I believe this was being worked on (on the side) but, IIRC, a snag was hit relative to converting the tests to pytest.

Looking at the list of PRs to port from Notebook, it looks like this effort would consist of the following...

jupyter/notebook#4835 (includes jupyter/notebook#5650, jupyter/notebook#5451, jupyter/notebook#5769)

@PromyLOPh
Copy link

Is there a branch with the current progress somewhere? Maybe we can figure this out together.

@Zsailer
Copy link
Member

Zsailer commented May 20, 2021

See #525.

@Zsailer
Copy link
Member

Zsailer commented May 25, 2021

Merged in #525. 🚀

@Zsailer Zsailer closed this as completed May 25, 2021
@PromyLOPh
Copy link

That was quick, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants