Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary import of requests_unixsocket #5451

merged 1 commit into from May 16, 2020


Copy link

@blink1073 blink1073 commented May 16, 2020

Follow up to #4835. This import gave a hard dependency on requests_unixsocket, which was caught by a failing docs build:

@blink1073 blink1073 added this to the 6.1 milestone May 16, 2020
Copy link
Member Author

cc @kwlzn, heads up for when you port to jupyter_server.

@blink1073 blink1073 merged commit 038b2c0 into jupyter:master May 16, 2020
Copy link

kwlzn commented May 16, 2020

ah, thanks - noted. remnant of a prior impl that was replaced with socket.socket.

@kevin-bates kevin-bates mentioned this pull request May 29, 2020
24 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants