-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bash-specific assumption #342
Comments
I think it would also be useful to allow the user to specify whatever arguments they wanted in the if os.name == 'nt':
default_shell = 'powershell.exe'
else:
default_shell = f"{which('sh')} -l"
shell = settings.get(
'shell_command',
os.environ.get('SHELL', default_shell).split()
) |
fyi: jupyter/notebook#5565 is slated for porting to server. We can then amend that to address these items. |
Hi @dhirschfeld - did you want to take a swing at a PR once #343 is merged? |
Sorry, I'm completely smashed at the moment. I'll try to get to it in the next couple of weeks so if someone else wants to pick it up before then feel free... |
In the initialize function
-l
is unconditionally appended to the shell arguments irrespective of whatever shell it is. Sincepwsh
is available on linux the logic should be updated to account for this.https://github.com/jupyter/jupyter_server/blob/e3de58b3be9865e25d653d0f47db8d929440d3ab/jupyter_server/terminal/__init__.py#L18-L27
The text was updated successfully, but these errors were encountered: