Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting basic templates from notebook #85

Closed
Zsailer opened this issue Sep 10, 2019 · 4 comments
Closed

Porting basic templates from notebook #85

Zsailer opened this issue Sep 10, 2019 · 4 comments
Labels
Milestone

Comments

@Zsailer
Copy link
Member

Zsailer commented Sep 10, 2019

There are various handlers that server basic templates (i.e. login/logout handlers). While Jupyter server doesn't seek to provide a frontend, hitting these handlers results in 500 errors.

I think we should port basic jinja templates for these handlers that can be overridden or inherited by extensions/subclasses.

@vidartf
Copy link
Member

vidartf commented Dec 14, 2019

Was this resolved in any way by code changes, or closed as "no action"?

@Zsailer Zsailer reopened this Dec 16, 2019
@Zsailer
Copy link
Member Author

Zsailer commented Dec 16, 2019

Oops, this was closed by mistake. I misread the issue. Thanks, @vidartf, for catching this.

@echarles echarles modified the milestones: 0.2.0 Release, 0.3.0 Release Jan 4, 2020
@Zsailer Zsailer modified the milestones: 0.3.0 Release, 1.0 Release Apr 15, 2020
@Mistobaan
Copy link
Contributor

I ended here trying to add the password to my server config file and getting a /login 500 because the html template is missing. There was a file added at some point but seems got lost?

@Zsailer
Copy link
Member Author

Zsailer commented May 5, 2020

Fixed in #220. Thanks, @Mistobaan!

@Zsailer Zsailer closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants