Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt native coroutines #93

Closed
kevin-bates opened this issue Sep 24, 2019 · 4 comments
Closed

Adopt native coroutines #93

kevin-bates opened this issue Sep 24, 2019 · 4 comments

Comments

@kevin-bates
Copy link
Member

Once Python 2 support has been removed (#63), we should update the coroutine decorators and associated backward compatible constructs to use native coroutines (async def and await).

@SylvainCorlay
Copy link
Contributor

There was a massive PR by @blink1073 #23 which did exactly that. At the time, it was decided to not go with this right away to remain closer to the notebook codebase for a little bit longer.

Maybe we want to go ahead with this now.

@kevin-bates
Copy link
Member Author

@SylvainCorlay - I'm sorry I didn't catch that - thanks (and thanks @blink1073!)

I think once we've brought over the remaining notebook commits, we should embark on such a thing. (I suppose we should hold off on #90 until then as well.) Do we have an enumeration of which commits we should cherry-pick?

@Zsailer
Copy link
Member

Zsailer commented Sep 24, 2019

Funny enough, I'm working on the notebook PR porting now...

@Zsailer Zsailer added this to the 0.3.0 Release milestone Dec 2, 2019
@Zsailer
Copy link
Member

Zsailer commented Apr 15, 2020

These were all updated in #191! 🎉 Closing!

@Zsailer Zsailer closed this as completed Apr 15, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
* fix handling of mode

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants