Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the concurrent futures in an asyncio future #1001

Merged
merged 1 commit into from Sep 27, 2022

Conversation

blink1073
Copy link
Collaborator

Follow up to #988

@blink1073 blink1073 added the bug label Sep 27, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 72.42% // Head: 72.38% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (c054752) compared to base (017c52e).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   72.42%   72.38%   -0.05%     
==========================================
  Files          64       64              
  Lines        8243     8249       +6     
  Branches     1378     1375       -3     
==========================================
+ Hits         5970     5971       +1     
- Misses       1855     1857       +2     
- Partials      418      421       +3     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 56.96% <60.00%> (-0.72%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 77.99% <0.00%> (-0.65%) ⬇️
jupyter_server/serverapp.py 65.49% <0.00%> (-0.10%) ⬇️
jupyter_server/services/contents/filemanager.py 70.84% <0.00%> (+0.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit dd8a693 into jupyter-server:main Sep 27, 2022
@blink1073 blink1073 deleted the use-asyncio-future-main branch September 27, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants