Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle client 8 pending kernels #1014

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

blink1073
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 72.52% // Head: 72.54% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e2df1ef) compared to base (ece308b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   72.52%   72.54%   +0.01%     
==========================================
  Files          64       64              
  Lines        8251     8257       +6     
  Branches     1257     1259       +2     
==========================================
+ Hits         5984     5990       +6     
  Misses       1851     1851              
  Partials      416      416              
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 58.05% <100.00%> (+0.26%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 78.84% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Collaborator Author

Failures are unrelated

@blink1073 blink1073 enabled auto-merge (squash) October 11, 2022 11:04
@blink1073 blink1073 merged commit 32de53b into jupyter-server:main Oct 11, 2022
@blink1073 blink1073 deleted the handle-shutdown-ready branch October 11, 2022 11:11
@blink1073
Copy link
Collaborator Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Oct 11, 2022
blink1073 added a commit that referenced this pull request Oct 11, 2022
)

Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants