Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject validation #1020

Merged
merged 2 commits into from Oct 9, 2022

Conversation

blink1073
Copy link
Collaborator

Use https://github.com/abravalheri/validate-pyproject to validate the pyproject.toml, including trove classifiers.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 72.57% // Head: 72.51% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (62bee8c) compared to base (bf26b59).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   72.57%   72.51%   -0.07%     
==========================================
  Files          64       64              
  Lines        8251     8251              
  Branches     1257     1257              
==========================================
- Hits         5988     5983       -5     
- Misses       1848     1852       +4     
- Partials      415      416       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 57.79% <0.00%> (-1.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 31cdf4d into jupyter-server:main Oct 9, 2022
@blink1073 blink1073 deleted the use-validate-pyproject branch October 9, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants