Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min version check again #1049

Merged

Conversation

blink1073
Copy link
Collaborator

  • Also add more checks to rollup check

@blink1073 blink1073 added the bug label Nov 4, 2022
@blink1073 blink1073 enabled auto-merge (squash) November 4, 2022 00:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 73.08% // Head: 73.01% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (f897ee6) compared to base (efba15a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   73.08%   73.01%   -0.07%     
==========================================
  Files          64       64              
  Lines        8269     8269              
  Branches     1642     1642              
==========================================
- Hits         6043     6038       -5     
- Misses       1820     1824       +4     
- Partials      406      407       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 61.56% <0.00%> (-1.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 87e0a01 into jupyter-server:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants