Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more coverage #1069

Merged
merged 15 commits into from Nov 17, 2022
Merged

Add more coverage #1069

merged 15 commits into from Nov 17, 2022

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Nov 12, 2022

  • Add more coverage for extension app and files handler (which was actually broken).
  • Get windows-specific coverage

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 75.14% // Head: 75.63% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (ad66cb9) compared to base (830c87f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   75.14%   75.63%   +0.48%     
==========================================
  Files          63       63              
  Lines        8225     8222       -3     
  Branches     1635     1634       -1     
==========================================
+ Hits         6181     6219      +38     
+ Misses       1624     1576      -48     
- Partials      420      427       +7     
Impacted Files Coverage Δ
jupyter_server/files/handlers.py 85.45% <100.00%> (+50.97%) ⬆️
jupyter_server/services/kernels/handlers.py 61.61% <0.00%> (-1.02%) ⬇️
jupyter_server/extension/serverextension.py 87.05% <0.00%> (+7.19%) ⬆️
jupyter_server/extension/utils.py 84.21% <0.00%> (+15.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Collaborator Author

Question: should we deprecate the previously broken FilesHandler class?

@blink1073
Copy link
Collaborator Author

We're going to keep the FileHandler class, since it is used by default for ContentsManager, while FileContentsManager uses the AuthenticatedFileHandler class. Both are actually authenticated, which is an unfortunate naming.

@blink1073 blink1073 merged commit 28577cf into jupyter-server:main Nov 17, 2022
@blink1073 blink1073 deleted the moar-coverage branch November 17, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant