New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
persist userid cookie when auth is disabled #1076
Conversation
allows unsetting auth
ensures stable userid for a given browser when auth is completely disabled
Codecov ReportBase: 76.23% // Head: 76.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 76.23% 76.22% -0.01%
==========================================
Files 63 63
Lines 8226 8228 +2
Branches 1636 1637 +1
==========================================
+ Hits 6271 6272 +1
- Misses 1548 1550 +2
+ Partials 407 406 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll wait for others to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minrk, I checked that it fixes jupyterlab/jupyterlab#13432.
Thank you, Min, for the fixing this so quickly! |
Thanks for the fix Min! |
Thanks Min!
…On Fri, Nov 18, 2022 at 10:23 AM Carlos Herrero ***@***.***> wrote:
Thanks for the fix Min!
—
Reply to this email directly, view it on GitHub
<#1076 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXUC7PIEBIYB5DUUEY73WI7CR3ANCNFSM6AAAAAASEICLQ4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Brian E. Granger
Senior Principal Technologist, AWS AI/ML ***@***.***)
On Leave - Professor of Physics and Data Science, Cal Poly
@ellisonbg on GitHub
|
Allows a stable anonymous user, persisted via cookie (just like a token login).
closes #1033