Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more serverapp tests #1079

Merged
merged 14 commits into from
Nov 21, 2022
Merged

Conversation

blink1073
Copy link
Collaborator

Also upload coverage from integration tests

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 76.53% // Head: 78.01% // Increases project coverage by +1.48% 🎉

Coverage data is based on head (615bb03) compared to base (f583a11).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
+ Coverage   76.53%   78.01%   +1.48%     
==========================================
  Files          68       68              
  Lines        8305     8298       -7     
  Branches     1655     1652       -3     
==========================================
+ Hits         6356     6474     +118     
+ Misses       1542     1424     -118     
+ Partials      407      400       -7     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 67.82% <0.00%> (+0.84%) ⬆️
jupyter_server/auth/identity.py 86.28% <0.00%> (+1.51%) ⬆️
jupyter_server/utils.py 83.79% <0.00%> (+5.02%) ⬆️
jupyter_server/serverapp.py 76.76% <0.00%> (+8.92%) ⬆️
jupyter_server/auth/authorizer.py 100.00% <0.00%> (+15.38%) ⬆️
jupyter_server/services/shutdown.py 100.00% <0.00%> (+23.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 12f7c1d into jupyter-server:main Nov 21, 2022
@blink1073 blink1073 deleted the serverapp_coverage branch November 21, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant