Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado WebSocketHandler fixup #1083

Merged
merged 2 commits into from Nov 21, 2022
Merged

Conversation

davidbrochart
Copy link
Contributor

Fixes #1081.

@davidbrochart
Copy link
Contributor Author

Although jupyterlab-lsp should not import Tornado's WebSocketHandler from jupyter_server.base.zmqhandlers, but from tornado.websocket directly.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 78.07% // Head: 78.05% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (7e033d5) compared to base (96a4f6a).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   78.07%   78.05%   -0.03%     
==========================================
  Files          68       68              
  Lines        8298     8299       +1     
  Branches     1652     1652              
==========================================
- Hits         6479     6478       -1     
- Misses       1420     1421       +1     
- Partials      399      400       +1     
Impacted Files Coverage Δ
...ter_server/services/kernels/connection/channels.py 47.48% <0.00%> (ø)
jupyter_server/base/zmqhandlers.py 100.00% <100.00%> (ø)
jupyter_server/serverapp.py 76.59% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 5f84e96 into jupyter-server:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not start kernel with jupyterlab 4.0.0a31
3 participants