Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #1092

Merged
merged 7 commits into from
Nov 24, 2022
Merged

Add more tests #1092

merged 7 commits into from
Nov 24, 2022

Conversation

blink1073
Copy link
Collaborator

This might get us to 80%...

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 79.39% // Head: 80.30% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (a7df1db) compared to base (2206a47).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   79.39%   80.30%   +0.91%     
==========================================
  Files          68       68              
  Lines        8294     8297       +3     
  Branches     1652     1652              
==========================================
+ Hits         6585     6663      +78     
+ Misses       1284     1202      -82     
- Partials      425      432       +7     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 90.53% <50.00%> (-0.55%) ⬇️
...ter_server/services/kernels/connection/channels.py 58.38% <0.00%> (-1.09%) ⬇️
jupyter_server/extension/manager.py 92.68% <0.00%> (ø)
jupyter_server/serverapp.py 80.12% <0.00%> (+3.35%) ⬆️
jupyter_server/services/contents/fileio.py 90.00% <0.00%> (+15.26%) ⬆️
jupyter_server/base/websocket.py 68.11% <0.00%> (+21.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) November 24, 2022 04:28
@blink1073
Copy link
Collaborator Author

Woohoo!

@blink1073 blink1073 merged commit e9735fc into jupyter-server:main Nov 24, 2022
@blink1073 blink1073 deleted the more-testing branch November 24, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant