Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint rule #1128

Merged
merged 6 commits into from Dec 13, 2022
Merged

Fix lint rule #1128

merged 6 commits into from Dec 13, 2022

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Dec 12, 2022

Addresses warning: `I252` has been remapped to `TID252` error seen in CI.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 80.04% // Head: 80.04% // No change to project coverage 👍

Coverage data is based on head (4029d70) compared to base (a55bc58).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          68       68           
  Lines        8040     8040           
  Branches     1588     1588           
=======================================
  Hits         6436     6436           
  Misses       1182     1182           
  Partials      422      422           
Impacted Files Coverage Δ
jupyter_server/extension/application.py 73.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Collaborator Author

Ugh, we can't fix this for another 8 hours until the next sync on https://github.com/charliermarsh/ruff-pre-commit/commits/main, since 0.0.177 changes the way imports are formatted.

@blink1073 blink1073 enabled auto-merge (squash) December 13, 2022 02:15
@blink1073 blink1073 merged commit e9b18e9 into jupyter-server:main Dec 13, 2022
@blink1073 blink1073 deleted the fix-ruff-config branch December 13, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant