Restore default writing of browser open redirect file, add opt-in to skip

[bollwyvl]

Elevator Pitch

Make skipping the browser open files opt-in.

References

• fixes 2.0.2 reports location of browser launch file, but does not create it #1143

Changes

• add ServerApp.no_browser_open_file, defaulting to False
• gate writing of the browser redirect file behind this setting
• update printed message to not show the message if the file was not written
  • add a little i18n to the text
• add test of no_browser_open_file and false, check for file creation and log message

Alternatives

• make browser_open_file allow_none=True
  • this is probably clearer, and wouldn't introduce a new config variable, but Nones do weird things

[bollwyvl]

Ha, i can see why this didn't get caught earlier. 😿

          test_command: "python -m jupyterlab.browser_check --no-browser-test"

[codecov]

Codecov Report

Base: 79.84% // Head: 80.03% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (230de3b) compared to base (1c9c943).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   79.84%   80.03%   +0.18%     
==========================================
  Files          68       68              
  Lines        8048     8053       +5     
  Branches     1598     1600       +2     
==========================================
+ Hits         6426     6445      +19     
+ Misses       1200     1184      -16     
- Partials      422      424       +2     

Impacted Files	Coverage Δ
jupyter_server/serverapp.py	80.19% <100.00%> (+0.87%)	⬆️
...ter_server/services/kernels/connection/channels.py	59.82% <0.00%> (+1.10%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bollwyvl]

coverage sad, but them's the brakes. Happy to add a test, but the best one, mentioned above, is presently explicitly disabled.

[bollwyvl]

80.03% (+0.18%) compared to 1c9c943

Ha, and back over 80 to boot.

[blink1073]

Thank you!