Use repr in logging for exception. #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use exc_info=True instead of a separate log.exception to make sure the tb is attached to the right log message. Using `%s` can have issue when logging error as it may hide informations like the type of exception. If for example you have an assertion error, %s will give you the empty string, which is not informative. On the other hand, %r will _at least_ give you `AssertionError()`, which is a start.
Codecov ReportBase: 79.93% // Head: 80.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
==========================================
+ Coverage 79.93% 80.16% +0.23%
==========================================
Files 68 68
Lines 8124 8149 +25
Branches 1601 1605 +4
==========================================
+ Hits 6494 6533 +39
+ Misses 1205 1189 -16
- Partials 425 427 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use exc_info=True instead of a separate log.exception to make sure the tb is attached to the right log message.
Using
%scan have issue when logging error as it may hide informations like the type of exception. If for example you have an assertion error, %s will give you the empty string, which is not informative.On the other hand, %r will at least give you
AssertionError(), which is a start.