Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license 2 (#1196 #1196

Merged
merged 2 commits into from Feb 2, 2023
Merged

Add license 2 (#1196 #1196

merged 2 commits into from Feb 2, 2023

Conversation

dcsaba89
Copy link
Contributor

@dcsaba89 dcsaba89 commented Feb 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 79.14% // Head: 80.36% // Increases project coverage by +1.21% 🎉

Coverage data is based on head (4f8b923) compared to base (f3fe168).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   79.14%   80.36%   +1.21%     
==========================================
  Files          68       68              
  Lines        8117     8117              
  Branches     1584     1584              
==========================================
+ Hits         6424     6523      +99     
+ Misses       1280     1178     -102     
- Partials      413      416       +3     
Impacted Files Coverage Δ
jupyter_server/log.py 100.00% <ø> (ø)
...ter_server/services/kernels/connection/channels.py 61.06% <0.00%> (-1.11%) ⬇️
jupyter_server/base/handlers.py 78.82% <0.00%> (+0.58%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (+5.81%) ⬆️
jupyter_server/serverapp.py 79.94% <0.00%> (+7.80%) ⬆️
jupyter_server/services/shutdown.py 100.00% <0.00%> (+23.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 changed the title Add license 2 Add license 2 (#1196 Feb 2, 2023
@blink1073 blink1073 merged commit 841a637 into jupyter-server:main Feb 2, 2023
@welcome
Copy link

welcome bot commented Feb 2, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 2, 2023

hi @blink1073, unfortunately I think simply renaming the top level license file to LICENSE just did not work.

You can compare this [https://github.com/ipython/ipython/blob/main/LICENSE]
with this [https://github.com/jupyter-server/jupyter_server/blob/main/LICENSE], I still not able able to see the license badge and I think the reason for that is maybe the original COPYING.md was not properly created according to the official description: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants