Fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir (#1223 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this flag prevents deprecated `notebook_dir` config from having higher priority than newer config
minrk
force-pushed
the
fix-root-dir-priority
branch
from
d8cdb18
to
b7afe82
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
==========================================
+ Coverage 80.38% 80.45% +0.07%
==========================================
Files 68 68
Lines 8249 8253 +4
Branches 1602 1603 +1
==========================================
+ Hits 6631 6640 +9
+ Misses 1196 1189 -7
- Partials 422 424 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
blink1073
changed the title
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_root_dir_setflag prevents deprecatednotebook_dirconfig from being loaded at a higher priority than newerroot_dirconfig.This config is relatively likely to be set, as
notebook_shimmeans that legacy config, which should not be removed, is still loaded into ServerApp, so anyone who still has notebook config present for working with the older server will still get this config set on the new server, and it should be ignored in favor of newer config.