Skip dir size check if not enumerable #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows or other platforms that cannot run `du` successfully, we should still allow users to copy directories, but log a warning to indicate that there might be a degraded performance of their UI if the folder is large.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 80.35% 80.43% +0.07%
==========================================
Files 68 68
Lines 8253 8253
Branches 1603 1603
==========================================
+ Hits 6632 6638 +6
+ Misses 1195 1191 -4
+ Partials 426 424 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vidartf
added
enhancement
backwards compat
python
kevin-bates
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
These changes look good - thanks @vidartf. (Thanks for addressing the lint failure as well.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows or other platforms that cannot run
dusuccessfully, we should still allow users to copy directories, but log a warning to indicate that there might be a degraded performance of their UI if the folder is large.Follow up to #1190 .