Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable websocket ping/pong from the server #1243

Merged
merged 1 commit into from Mar 23, 2023

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Mar 23, 2023

Looks like a minor regression was introduced by #1047

The server-side ping/pong on the kernel websockets as dropped when I refactored the websocket API.

@Zsailer Zsailer added the bug label Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (2d01f84) 80.37% compared to head (d7ed34b) 80.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   80.37%   80.36%   -0.01%     
==========================================
  Files          68       68              
  Lines        8263     8264       +1     
  Branches     1600     1600              
==========================================
  Hits         6641     6641              
  Misses       1200     1200              
- Partials      422      423       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/websocket.py 80.39% <100.00%> (+0.39%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 702c248 into jupyter-server:main Mar 23, 2023
36 of 37 checks passed
@Zsailer Zsailer deleted the re-enable-ws-ping branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants