Make the kernel_websocket_protocol flag reusable. #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the `kernel_websocket_protocol` flag out from the sub-class `ZMQChannelsWebsocketConnection` and into its base class `BaseKernelWebsocketConnection` so that it is automatically available to any other sub classes of `BaseKernelWebsocketConnection`.
kevin-bates
approved these changes
May 10, 2023
ojarjur
added a commit
to ojarjur/jupyter_server
that referenced
this pull request
May 10, 2023
…socketConnection This change removes a temporary work-around to the required `kernel_ws_protocol` field not being defined in the `BaseKernelWebsocketConnection` base class. Previously, that field was only defined in the ZMQChannelsWebsocketConnection class, so we had to reproduce it in the `GatewayWebsocketConnection` class in order to get that class to work correctly. However, we only provided a minimal default value of `None` rather than properly supporting the user setting their preferred websocket protocol. This workaround was made unnecessary by jupyter-server#1264 which moved the `kernel_ws_protocol` field from the ZMQChannelsWebsocketConnection class to the base class. Accordingly, this commit removes that temporary work-around that is no longer needed. We needed to provide a value for that,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the
kernel_websocket_protocolflag out from the sub-classZMQChannelsWebsocketConnectionand into its base classBaseKernelWebsocketConnectionso that it is automatically available to any other sub classes ofBaseKernelWebsocketConnection.