Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on invalid JSON in page_config (#1403) #1404

Merged
merged 1 commit into from Mar 12, 2024

Conversation

holzman
Copy link
Contributor

@holzman holzman commented Mar 12, 2024

Addresses #1403

Copy link

welcome bot commented Mar 12, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Zsailer
Copy link
Member

Zsailer commented Mar 12, 2024

Looks good to me. Thanks @holzman!

@Zsailer Zsailer merged commit f26c1a0 into jupyter-server:main Mar 12, 2024
34 of 37 checks passed
Copy link

welcome bot commented Mar 12, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants