Update log messages when testing for load_jupyter_server_extension method #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* flatten kernel launch logic * remove duplicated code for modes * remove unnecessary comment * cleanup some more comments * revert name of mode methods in provisioner * fix local mode method name * condense mode specific methods to a single method in provisioner
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…ning-message Update log messages when testing for load_jupyter_server_extension method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking in serverapp for
load_jupyter_server_extensionor_load_jupyter_server_extension, this PR reduces the scope of the except (only catch AttributeError and not other exceptions as this may hide other issues).It also logs a warning if
load_jupyter_server_extensioninstead of the preferred_load_jupyter_server_extension.