Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel independent logging #231

Closed
wants to merge 1 commit into from
Closed

Conversation

gclen
Copy link

@gclen gclen commented May 17, 2020

This moves jupyter/notebook#2252 to jupyter_server. I think it is useful to have the ability to log which code has been executed (for auditability reasons).

The method of specifying a python logger is clunky and I'm looking for suggestions on ways to improve that (specifying the logger in a traitlets config file?).

Pinging @Zsailer

@Zsailer
Copy link
Member

Zsailer commented May 19, 2020

Thanks, @gclen! Pinging @kevin-bates for his thoughts, too.

@kevin-bates
Copy link
Member

Thanks for starting this @gclen.

I like the idea and think this could be generally useful - especially in larger installations. It feels like a great fit as an event source for the Jupyter Telemetry project and makes sense to leverage for this.

I would imagine we'd include more data about the kernel "session" (user, kernel-id, kernel-name, provider, etc.) that could then be used to differentiate activity, either via cross-referencing (via kernel-id) or directly.

@Zsailer
Copy link
Member

Zsailer commented May 19, 2020

Sorry—I didn't have time to look at this closely yesterday. I thought this was directed at developers for debugging purposes, not at operators/administrators auditing the server.

I agree with Kevin. This should be handled by telemetry instead.

I'll draft a PR that adds telemetry to the server this afternoon.

@Zsailer
Copy link
Member

Zsailer commented May 20, 2020

See #233 for a draft of telemetry/event logging in Jupyter server.

@Zsailer
Copy link
Member

Zsailer commented May 29, 2020

I'm going to close this PR in favor of #233.

That said, @gclen it would be great to work with you on developing an event schema for the kernels API. As someone who is interested in logging/auditing kernels, you have super valuable insight there.

@Zsailer
Copy link
Member

Zsailer commented May 29, 2020

Checkout #238 for initial discussion on drafting a kernels schema.

Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* Upgrade to JupyterLab 3.2

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants