add check_origin handler to gateway WebSocketChannelsHandler #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Nov 15, 2020
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
Dec 10, 2020
…ebSocketChannelsHandler
Zsailer
added a commit
that referenced
this pull request
Dec 10, 2020
…on-1.0.x Backport PR #340 on branch 1.0.x (add check_origin handler to gateway WebSocketChannelsHandler)
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add a kernel info section to the advanced tools section * add process/Pod ID to kernel info * UI: kernel info item components * rename to process id to pod id in kernel_info UI * relax testing thresholds in UI
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
add check_origin handler to gateway WebSocketChannelsHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already merged on jupyter/notebook:
https://github.com/jupyter/notebook/blob/cd7a06ce88387b70c3dbe1bca6ab5ae222e28c60/notebook/gateway/handlers.py#L35
It makes sure the Websocket handler of the Gateway respects the user config of allow_origin.
Happy to change anything if this is not correct/desired for the jupyter_server repo!