Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port gateway updates from notebook (PRs 5317 and 5484) #341

Merged
merged 3 commits into from
Nov 17, 2020

Commits on Nov 15, 2020

  1. Gateway only: Ensure launch and request timeouts are in sync (#5317)

    Prior to this change, the request timeout for a Gateway request
    was synchronized with KERNEL_LAUNCH_TIMEOUT only if KLT
    was greater. However, the two are closely associated and KLT
    should be adjusted if the configurable request_timeout is greater.
    This change ensures that the two values are synchronized to the
    greater value. It changes the two configurable timeouts to default
    to 40 (to match that of KLT) and removes the 2-second pad,
    since that wasn't helpful and only confused the situation.
    
    These changes were prompted by this issue: jupyter-server/enterprise_gateway#792
    kevin-bates committed Nov 15, 2020
    3 Configuration menu
    Copy the full SHA
    573adc3 View commit details
    Browse the repository at this point in the history
  2. Added functionality to allow filter kernels by Jupyter Enterprise Gat…

    …eway using KERNEL_USERNAME env var
    lucabem authored and kevin-bates committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    b8da0a8 View commit details
    Browse the repository at this point in the history
  3. Changed _get_endpoint_for_user_filter to static and used in construct…

    …or class instead of each class method
    lucabem authored and kevin-bates committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    c386729 View commit details
    Browse the repository at this point in the history