Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trust handle use ensure_async #373

Merged
merged 3 commits into from Jan 5, 2021
Merged

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Jan 5, 2021

Fixes #372.

Blind edit via web, so not tested yet. I'll see if I can add a regression test as well.

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #373 (ee6c909) into master (00a6e25) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   69.29%   69.35%   +0.06%     
==========================================
  Files          56       56              
  Lines        6135     6135              
  Branches      804      804              
==========================================
+ Hits         4251     4255       +4     
+ Misses       1616     1612       -4     
  Partials      268      268              
Impacted Files Coverage Δ
jupyter_server/services/contents/handlers.py 84.17% <100.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a6e25...ee6c909. Read the comment docs.

@vidartf vidartf marked this pull request as ready for review January 5, 2021 14:14
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good Vidar and are consistent with what the code was doing before the async/await sweep. Thanks for adding the test as well!

The current test snafus appear to be unrelated.

@kevin-bates kevin-bates merged commit 60c66b6 into master Jan 5, 2021
@vidartf vidartf deleted the ensure-trust-async branch January 5, 2021 15:08
@Zsailer
Copy link
Member

Zsailer commented Jan 5, 2021

The current test snafus appear to be unrelated.

Yeah, oddly, culling kernels on any OS using PyPy seems to take an unpredictable/flaky amount of time (see this line).

I'll cut a patch release with these changes today.

hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…t-async

Make trust handle use ensure_async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue trusting notebook (using nbclassic)
4 participants