Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconnection to Gateway #378

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

oyvsyo
Copy link

@oyvsyo oyvsyo commented Jan 8, 2021

Mirror logic from
jupyter/notebook#5924
that implements an exponential backoff algorithm and retry count
limit to prevent too many false API calls in error trying to reconnect to an orphaned session

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #378 (ee2b12d) into master (d4438a2) will decrease coverage by 0.01%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   69.08%   69.06%   -0.02%     
==========================================
  Files          56       56              
  Lines        6194     6220      +26     
  Branches      816      816              
==========================================
+ Hits         4279     4296      +17     
- Misses       1641     1650       +9     
  Partials      274      274              
Impacted Files Coverage Δ
jupyter_server/gateway/handlers.py 32.29% <20.00%> (-0.39%) ⬇️
jupyter_server/gateway/managers.py 77.58% <84.21%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4438a2...ee2b12d. Read the comment docs.

@oyvsyo oyvsyo marked this pull request as ready for review January 8, 2021 17:08
@oyvsyo
Copy link
Author

oyvsyo commented Jan 8, 2021

@kevin-bates Is it ok?

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stepan - this looks good.

@kevin-bates kevin-bates merged commit 0f8d89d into jupyter-server:master Jan 8, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* minor bug fix in culling logic

* Bump to 0.19.7
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants