Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application exit #384

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Fix application exit #384

merged 1 commit into from
Jan 14, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 14, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #384 (7a04ce2) into master (3135bd6) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   69.28%   69.25%   -0.04%     
==========================================
  Files          56       56              
  Lines        6128     6131       +3     
  Branches      798      798              
==========================================
  Hits         4246     4246              
- Misses       1616     1619       +3     
  Partials      266      266              
Impacted Files Coverage Δ
jupyter_server/extension/application.py 61.34% <20.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3135bd6...7a04ce2. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The test failures appear unrelated to this PR. I'm not sure what's happening on PyPy... Merging as-is.

@Zsailer Zsailer merged commit b862930 into jupyter-server:master Jan 14, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants