Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase culling test idle timeout #388

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

kevin-bates
Copy link
Member

This is a port of jupyter/notebook#5952 to increase the kernel idle timeout for the culling test. Since there was already an increased timeout for 'PyPy', I kept that value (10) in place, although I suspect the new value (5) would be sufficient.

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #388 (083f7be) into master (1b7f6fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          56       56           
  Lines        6131     6131           
  Branches      798      798           
=======================================
  Hits         4246     4246           
  Misses       1619     1619           
  Partials      266      266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7f6fe...083f7be. Read the comment docs.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit b5fed9c into jupyter-server:master Jan 19, 2021
@kevin-bates kevin-bates deleted the cull-test-idle-timeout branch February 1, 2021 22:49
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…-timeout

Increase culling test idle timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants